search

uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
339 stars 128 forks source link

Introduce DisableStrictNonDeterminismCheck worker option #1288

Closed taylanisikdemir closed 8 months ago

taylanisikdemir commented 8 months ago

What changed? Adding a new option to be able to toggle non-determinism false positives fix in #1281.

Why? The strict non-determinism checks in #1281 may cause some existing workflows to fail due to the existing buggy non-determinism checks in task handling loop. So exposing this option to disable the strict non-determinism if needed.

How did you test it?

1281 will be rebased with this change and testing will be done there.

Potential risks N/A

Groxx commented 8 months ago

since we'll be enabling this by default, we probably want this flag to be reversed, yea?

doing it gradually could work too (say over a couple versions), but that'd still need to change the name or type of the field, which we essentially can't do.

taylanisikdemir commented 8 months ago

since we'll be enabling this by default, we probably want this flag to be reversed, yea?

doing it gradually could work too (say over a couple versions), but that'd still need to change the name or type of the field, which we essentially can't do.

Synced offline on this and agreed to enable by default so reversing the bool option to disable when needed.