search

uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
339 stars 128 forks source link

Add GetActivityTaskList and GetWorkflowTaskList utils to replace WithTaskListMapper utils #1292

Closed shijiesheng closed 8 months ago

shijiesheng commented 8 months ago

What changed?

Remove WithTasklist utils introduced in https://github.com/uber-go/cadence-client/pull/1286 Instead, users should use the new GetTaskList and With*TaskList APIs.

For future as discussed with @Groxx, it's better to have a functional API to replace all "With*".

For example: ExecuteChildWorkflow(ctx, type, child.Args(all, args), child.WorkflowID("asdf'))

Why? With**TaskList APIs are confusing and it's better to remove it

How did you test it?

Potential risks