search

uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
339 stars 128 forks source link

downgrade thrift to backend compatible version #1306

Open 3vilhamster opened 6 months ago

3vilhamster commented 6 months ago

What changed? I downgraded apache/thrfit version to the version compatible on the Cadence backend.

Why? Cadence backend uses client to run internal operations, so client should be compatible with the backend.

How did you test it? unit tests/integration tests

Potential risks Potential failures for customers using up to date thrift version.

Groxx commented 4 months ago

Hmm 🤔 I get how this is a problem with our old pinned version internally but... why hasn't it been a problem all along? Seems like this probably changed at #1189 so it has been in place for quite a while / we have definitely upgraded past that internally.

3vilhamster commented 4 months ago

hmm in the monorepo the version is set to 0.17.0 and it client works. Let me try 0.17.0 then, might be it will be fine.