search

uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
339 stars 128 forks source link

Fix coverage metadata commit info #1323

Closed taylanisikdemir closed 3 months ago

taylanisikdemir commented 3 months ago

What changed? Coverage metadata file generated by unit-test CI job was missing commit information

commit-sha: 
timestamp: 2024-03-15T18:37:21Z

Switching to buildkite env vars to retrieve commit information.

Why? The .build/metadata.txt file contains commit sha and timestamp of the corresponding .build/cover.out file. This is used to integrate with 3rd party coverage tools such as Sonarqube.

How did you test it? Ran the script locally by setting buildkite env vars. Will check how it does on master CI run after merge.

codecov[bot] commented 3 months ago

Codecov Report

Merging #1323 (e4033d3) into master (f578fed) will not change coverage. The diff coverage is n/a.

Additional details and impacted files ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber-go/cadence-client/pull/1323?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber-go/cadence-client/pull/1323?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go). Last update [f578fed...e4033d3](https://app.codecov.io/gh/uber-go/cadence-client/pull/1323?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go).