uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
339 stars 128 forks source link

Enforce 85% new line coverage #1325

Closed taylanisikdemir closed 3 months ago

taylanisikdemir commented 3 months ago

What changed? Updating codecov's patch setting to enforce new line coverage is above 85%. Similar to what we have on Cadence repo: https://github.com/uber/cadence/pull/5805

codecov[bot] commented 3 months ago

Codecov Report

Merging #1325 (6dd59dc) into master (81a37e4) will not change coverage. The diff coverage is n/a.

Additional details and impacted files ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber-go/cadence-client/pull/1325?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go) > `Ξ” = absolute (impact)`, `ΓΈ = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber-go/cadence-client/pull/1325?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go). Last update [81a37e4...6dd59dc](https://app.codecov.io/gh/uber-go/cadence-client/pull/1325?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go).
taylanisikdemir commented 3 months ago

sgtm πŸ‘

how do we work around this if it's too much red tape? there's always the admin-merge of course, but is there another option?

I didn't see a bypass option via tag etc. exposed by codecov. Current options are:

Groxx commented 3 months ago

reasonably discoverable workarounds anyway. makes sense πŸ‘