search

uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
339 stars 128 forks source link

Update client wrappers with new async APIs #1327

Closed taylanisikdemir closed 3 months ago

taylanisikdemir commented 3 months ago

What changed? Updating client wrappers to expose new async methods.

These changes were missed in #1321.

How did you test it? Unit test

codecov[bot] commented 3 months ago

Codecov Report

Merging #1327 (2a5e110) into master (68afcb9) will increase coverage by 0.31%. The diff coverage is 87.87%.

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber-go/cadence-client/pull/1327?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go) | Coverage Δ | | |---|---|---| | [internal/client.go](https://app.codecov.io/gh/uber-go/cadence-client/pull/1327?src=pr&el=tree&filepath=internal%2Fclient.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `61.38% <ø> (ø)` | | | [internal/workflow.go](https://app.codecov.io/gh/uber-go/cadence-client/pull/1327?src=pr&el=tree&filepath=internal%2Fworkflow.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go#diff-aW50ZXJuYWwvd29ya2Zsb3cuZ28=) | `77.44% <ø> (ø)` | | | [internal/internal\_workflow\_client.go](https://app.codecov.io/gh/uber-go/cadence-client/pull/1327?src=pr&el=tree&filepath=internal%2Finternal_workflow_client.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go#diff-aW50ZXJuYWwvaW50ZXJuYWxfd29ya2Zsb3dfY2xpZW50Lmdv) | `63.62% <87.87%> (+4.80%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/uber-go/cadence-client/pull/1327/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber-go/cadence-client/pull/1327?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber-go/cadence-client/pull/1327?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go). Last update [68afcb9...2a5e110](https://app.codecov.io/gh/uber-go/cadence-client/pull/1327?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go).
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 018e9ca6-a094-49e0-99cd-bf58edb8502c

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/internal_workflow_client.go 182 202 90.1%
mocks/Client.go 0 40 0.0%
<!-- Total: 182 242 75.21% -->
Files with Coverage Reduction New Missed Lines %
internal/internal_workflow_client.go 1 79.68%
internal/common/util/util.go 2 53.85%
internal/compatibility/thrift/enum.go 4 21.2%
internal/compatibility/thrift/types.go 9 48.42%
<!-- Total: 16 -->
Totals Coverage Status
Change from base Build 018e9b74-9b30-4551-ad2c-6499bdf01cbf: 0.02%
Covered Lines: 13376
Relevant Lines: 20678
💛 - Coveralls