search

uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
339 stars 128 forks source link

Server-like `make build` and ensuring builds are clean in CI #1329

Closed Groxx closed 3 months ago

Groxx commented 3 months ago

There's more work to be done, but it's a major step towards forcing stability.

Oddly, missing the safe.directory git setting leads to Go failing to get version info, leading to errors building, but for some reason it doesn't show the error that git's reporting (missing safe directory). Just stuff like this with no other output:

error obtaining VCS status:
    Use -buildvcs=false to disable VCS stamping.

Once I fixed that, I learned that go test -exec nonexistent ./... >/dev/null errors, but the "FAIL: command nonexistent not found" error is.... reported on stdout, so it's hidden. And so is the "FAIL the/package/name" message. But if you have a failing build, the failure is printed to stderr:

❯ go test -exec true ./... >/dev/null
# go.uber.org/cadence/evictiontest
evictiontest/workflow_cache_eviction_test.go:58:4: missing ',' in composite literal

I have no idea why -exec nonexistent isn't on stderr, but I left a comment in the makefile anyway.

Quite a large amount of weird stuff condensed into a seemingly simple goal.

codecov[bot] commented 3 months ago

Codecov Report

Merging #1329 (20b4c8d) into master (a55fc13) will not change coverage. The diff coverage is n/a.

Additional details and impacted files ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber-go/cadence-client/pull/1329?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber-go/cadence-client/pull/1329?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go). Last update [a55fc13...20b4c8d](https://app.codecov.io/gh/uber-go/cadence-client/pull/1329?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go).