codecov[bot]
commented
3 months ago Codecov Report
Merging #1331 (4ce7834) into master (08b284a) will not change coverage. The diff coverage is
n/a.
Closed Groxx closed 3 months ago
codecov[bot]
commented
3 months ago Merging #1331 (4ce7834) into master (08b284a) will not change coverage. The diff coverage is
n/a.
coveralls
commented
3 months ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| internal/compatibility/thrift/enum.go | 4 | 21.2% | ||
| internal/compatibility/thrift/types.go | 9 | 48.42% | ||
| <!-- | Total: | 13 | --> |
| Totals | |
|---|---|
| Change from base Build 018e9ff9-d8ed-403a-8c3a-5ffe0c57f644: | -0.05% |
| Covered Lines: | 13378 |
| Relevant Lines: | 20678 |
Followups from #1327:
1 is pretty simple: memos and search attrs are ALWAYS JSON because the server must interpret them, so the exact bytes should not change in the future. A hardcoded string is easy to verify, and strengthens the guarantee that "this should not change even if other encoding changes".
2 is more interesting: as originally written, the test would still pass if the custom dataconverter was not saved and used. The type-assertion to check the internal field somewhat prevents that, but it's unnecessary and a disjointed check. So it has been rewritten: now the serialized request bytes must clearly come from the test encoder, not the default encoder, and they must be detectably different.