search

uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.
https://cadenceworkflow.io
MIT License
339 stars 128 forks source link

Documentation fix in MinConcurrentDecisionTaskPollers #1340

Open subhash-veluru opened 1 month ago

subhash-veluru commented 1 month ago

What changed? Have changed the description of MinConcurrentDecisionTaskPollers.

Why? It was giving the opposite meaning of what it was supposed to give. It was depicted that changing this value would not take effect if PollerAutoScaler is set to true, but it was supposed to be the opposite.

How did you test it? Just a documentation change

Potential risks None

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.20%. Comparing base (bf68484) to head (a9695c8).

:exclamation: Current head a9695c8 differs from pull request most recent head 9341acd

Please upload reports for the commit 9341acd to get more accurate results.

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber-go/cadence-client/pull/1340?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go) | Coverage Δ | | |---|---|---| | [internal/worker.go](https://app.codecov.io/gh/uber-go/cadence-client/pull/1340?src=pr&el=tree&filepath=internal%2Fworker.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go#diff-aW50ZXJuYWwvd29ya2VyLmdv) | `14.28% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/uber-go/cadence-client/pull/1340/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber-go/cadence-client/pull/1340?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber-go/cadence-client/pull/1340?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go). Last update [bf68484...9341acd](https://app.codecov.io/gh/uber-go/cadence-client/pull/1340?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber-go).