uber-go / config

Configuration for Go applications
https://godoc.org/go.uber.org/config
MIT License
448 stars 41 forks source link

Check for formatting and lint errors in CI #63

Closed akshayjshah closed 2 years ago

akshayjshah commented 7 years ago

We should check for correctness using gofmt, govet, and golint as part of Travis builds. We already do this in the rest of the Fx-related OSS projects, so we should be able to just copy those bits of Makefile.

akshayjshah commented 6 years ago

Primary issue here is that the code in expand.go is all C-style and snake_case, so it doesn't pass our typical linter suite. We'll need to fix that file before we can move forward with this.

akshayjshah commented 2 years ago

Seems like this got done 🎉