search

uber-go / config

Configuration for Go applications
https://godoc.org/go.uber.org/config
MIT License
448 stars 41 forks source link

[WIP] Handle empty sources correctly #92

Closed akshayjshah closed 6 years ago

akshayjshah commented 6 years ago

When reading empty files (or using otherwise empty sources), we need to handle io.EOF correctly. Special-case end-of-file where relevant, and document why we don't need to handle it elsewhere.

codecov[bot] commented 6 years ago

Codecov Report

Merging #92 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   95.54%   95.57%   +0.02%     
==========================================
  Files           8        8              
  Lines         382      384       +2     
==========================================
+ Hits          365      367       +2     
  Misses         11       11              
  Partials        6        6
Impacted Files Coverage Δ
config.go 90.15% <ø> (ø) :arrow_up:
internal/merge/merge.go 96.49% <100%> (+0.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2c8245...42f225d. Read the comment docs.

akshayjshah commented 6 years ago

Rethinking the approach here.