uber-go / dig

A reflection based dependency injection toolkit for Go.
https://go.uber.org/dig
MIT License
3.88k stars 206 forks source link

CI: test with Go 1.19 and Go 1.20 #376

Closed sywhang closed 8 months ago

sywhang commented 1 year ago

Only Go 1.19 and Go 1.20 are supported after Go 1.20 has been released.

This makes CI only run against Go 1.19 and Go 1.20.

codecov[bot] commented 1 year ago

Codecov Report

Merging #376 (c03bcf5) into master (c8f963c) will decrease coverage by 0.09%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
- Coverage   98.35%   98.26%   -0.09%     
==========================================
  Files          21       21              
  Lines        1458     2254     +796     
==========================================
+ Hits         1434     2215     +781     
- Misses         15       29      +14     
- Partials        9       10       +1     
Impacted Files Coverage Δ
constructor.go 96.07% <0.00%> (-1.15%) :arrow_down:
scope.go 98.07% <0.00%> (-0.83%) :arrow_down:
result.go 98.93% <0.00%> (-0.08%) :arrow_down:
error.go 100.00% <0.00%> (ø)
group.go 100.00% <0.00%> (ø)
inout.go 100.00% <0.00%> (ø)
invoke.go 100.00% <0.00%> (ø)
provide.go 100.00% <0.00%> (ø)
decorate.go 100.00% <0.00%> (ø)
container.go 100.00% <0.00%> (ø)
... and 11 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

abhinav commented 1 year ago

Need to update staticcheck

sywhang commented 1 year ago

huh, weird. Looks like staticcheck has a bug - it reports scope as not being used when it clearly is being used.

internal/digtest/container.go:49:6: type scope is unused (U1000)
abhinav commented 1 year ago

Possibly "embed an alias" is enough of a corner case. Could probably narrow it down.

abhinav commented 8 months ago

This can be closed. It was superseded by #394