search

uber-go / dig

A reflection based dependency injection toolkit for Go.
https://go.uber.org/dig
MIT License
3.78k stars 206 forks source link

Visualize child scopes #403

Closed greeflas closed 5 months ago

greeflas commented 5 months ago

Hello!

This is fix for #402.

I'll appreciate your feedback 🙌

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a772ad7) 98.40% compared to head (f6953c9) 98.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #403 +/- ## ======================================= Coverage 98.40% 98.40% ======================================= Files 22 22 Lines 1505 1507 +2 ======================================= + Hits 1481 1483 +2 Misses 15 15 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sywhang commented 5 months ago

Thanks @greeflas! Ideally we would add some type of visual representation to highlight the different scopes, but i think this is better than what we have for now. I'll take a look at the implementation later tonight

greeflas commented 5 months ago

Thank you, guys, for the feedback!