Closed JacobOaks closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
45369ac
) 98.40% compared to head (dff4fbd
) 98.40%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
PR #404 attempted to improve the tests in
visualize_test.go
by requiring length equality on the expected/actual ctors.During CI, this actually uncovered a test failure:
This is because in this specific test case, the provide was never actually successful because of an error during provide (
t5 did not implement io.Reader
).This commit:
RequireProvide
which will fail if the provide fails.t5
to implementio.Reader
.fx.As
(fx.As
does not also provide the actual type)This supercedes #404.