Open rossb83 opened 1 year ago
@JacobOaks to take a look
Hey there,
Thanks for reporting this. There are actually a couple issues with the graph visualization in addition to this at the moment. For example, decorators aren't represented, and neither are modules. I've reproduced your bug and filed an internal ticket to update the graph visualization code and fix these issues, ref: GO-1797.
Describe the bug The
fx.Dotgraph
displayed when visualizing the dependency graph is incorrect when using the newfx.Private
variable.To Reproduce For the following code it prints as expected "foo\nbar" meaning
ModuleB
has a dependency onModuleA
andModuleC
has a dependency onAnotherModuleA
.Yet the![graphviz (3)](https://user-images.githubusercontent.com/2305163/210761586-5d52053e-e125-4e6e-a659-2c28ef26655e.svg)
fx.DotGraph
printed looks like this where the incorrect edge is highlighted in red.Expected behavior My expectation is the dotgraph look like this again the corrected edge is highlighted in red.![graphviz (4)](https://user-images.githubusercontent.com/2305163/210761468-f629fdaf-0f60-434c-aae1-7ec7c473d65d.svg)
Additional Context While this bug is a subtle point, the visualization helps a lot when using new features like
fx.Private
to determine usage is correctly understood and seeing an incorrect visualization creates confusion and makes the user think they are the ones doing something wrong.