search

uber-go / fx

A dependency injection based application framework for Go.
https://uber-go.github.io/fx/
MIT License
5.48k stars 283 forks source link

CI: test against go1.22 #1195

Closed JacobOaks closed 2 months ago

JacobOaks commented 2 months ago

This PR modifies CI to test against Go versions 1.21 and 1.22. To avoid forcing users to upgrade to 1.21, I kept go.mod version at 1.20.

Some tests had to be updated to pass in 1.22.

I can remove stack_120_test.go if there's a good argument for it, but my thoughts are that we should have a complete & passing test suite for every version >= go.mod's version.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.49%. Comparing base (0ee304c) to head (1c3fc51). Report is 1 commits behind head on master.

:exclamation: Current head 1c3fc51 differs from pull request most recent head 1d6a008. Consider uploading reports for the commit 1d6a008 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1195 +/- ## ========================================== - Coverage 98.73% 98.49% -0.25% ========================================== Files 31 34 +3 Lines 2851 2858 +7 ========================================== Hits 2815 2815 - Misses 29 36 +7 Partials 7 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.