uber-go / fx

A dependency injection based application framework for Go.
https://uber-go.github.io/fx/
MIT License
5.83k stars 290 forks source link

Rename stdlibErr to stdliberr or stderr #234

Closed yutongp closed 7 years ago

yutongp commented 7 years ago

for https://github.com/uber-go/fx/blob/master/ulog/log.go#L24

package-names: "Good package names are short and clear. They are lower case, with no under_scores or mixedCaps."

I like this convention because I know package names are all lower case so I can seperate them from private struct defined somewhere else. I think this convention applies to rename package as well.

So maybe 'stdliberr' or 'stderr'?

ascandella commented 7 years ago

@alsamylkin

ghost commented 7 years ago

https://github.com/uber-go/fx/pull/235