search

uber-go / goleak

Goroutine leak detector
MIT License
4.48k stars 148 forks source link

Remove no longer needed tracestack_new.go file #123

Closed alexandear closed 3 months ago

alexandear commented 3 months ago

The PR moves isTraceStack from the tracestack_new.go to options.go. The file tracestack_new.go became unnecessary after #79.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.14%. Comparing base (7f1444f) to head (22358d0).

:exclamation: Current head 22358d0 differs from pull request most recent head 8afe7a5

Please upload reports for the commit 8afe7a5 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #123 +/- ## ======================================= Coverage 99.14% 99.14% ======================================= Files 6 5 -1 Lines 234 234 ======================================= Hits 232 232 Misses 1 1 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

abhinav commented 3 months ago

The lint error seems to be because of golangci-lint upgrade. The newest version does not exclude fmt.* by default in errcheck.

abhinav commented 3 months ago

The lint error seems to be because of golangci-lint upgrade. The newest version does not exclude fmt.* by default in errcheck.

@sywhang I think to fix that, we may need to change the golangci config—or just fix the lint issue. Up to you.

sywhang commented 3 months ago

yeah, let me fix that.