uber-go / goleak

Goroutine leak detector
MIT License
4.48k stars 148 forks source link

Mark VerifyNone as a test Helper #75

Closed tallclair closed 2 years ago

tallclair commented 2 years ago

Mark VerifyNone(...) as a test Helper function, so that it reports the error at the call site, rather than leaks.go:78:.

From the go docs:

Helper marks the calling function as a test helper function. When printing file and line information, that function will be skipped. Helper may be called simultaneously from multiple goroutines.

This is useful for tests that verify go routines at multiple points, so failures can be more easily distinguished.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

tallclair commented 2 years ago

I'm waiting on approval from my org to sign the CLA, sorry I may have jumped the gun on this.

tallclair commented 2 years ago

Sorry for the delay. CLA is signed, and comments have been addressed.

abhinav commented 2 years ago

Thanks!