uber-go / goleak

Goroutine leak detector
MIT License
4.48k stars 148 forks source link

Allow checking for functions anywhere in the stack #80

Closed thomshutt closed 10 months ago

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 2 years ago

Codecov Report

Merging #80 (bd1f0a0) into master (5c9bf00) will increase coverage by 1.36%. The diff coverage is 95.00%.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   94.92%   96.29%   +1.36%     
==========================================
  Files           5        5              
  Lines         138      243     +105     
==========================================
+ Hits          131      234     +103     
- Misses          4        6       +2     
  Partials        3        3              
Impacted Files Coverage Δ
internal/stack/stacks.go 89.61% <92.85%> (+4.19%) :arrow_up:
options.go 99.03% <100.00%> (-0.97%) :arrow_down:

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

thomshutt commented 1 year ago

👋 This has been open for a while now; if there's anything you'd like me to change then let me know. Similarly if it's not functionality that you want to add then I can close the PR.

pohly commented 1 year ago

This would be useful for a more precise suppression of a goroutine in Kubernetes which is currently reported as being in time.Sleep.

brandur commented 1 year ago

@thomshutt Any chance you're still around to address those code changes? I was just about to file an issue over lacking this functionality before I found this PR because I needed it too.

abhinav commented 10 months ago

Superseded by #113 Closing