uber-go / mock

GoMock is a mocking framework for the Go programming language.
Apache License 2.0
1.82k stars 104 forks source link

Provide a flag to control generation of the invocation comment #105

Closed skitt closed 5 months ago

skitt commented 9 months ago

The invocation comment stores the complete details of all provided arguments, which may include paths to files. These aren't always consistent, which results in unwanted changes in the generated files (especially for CI checking for unexpected changes...).

Since the invocation isn't always useful, provide a flag to control whether the comment is generated. To preserve current behaviour this defaults to true (enabled).

Fixes #104.

CLAassistant commented 9 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

ewhauser commented 8 months ago

@skitt - Can you sign the CLA so that this gets merged? Thank you!

skitt commented 8 months ago

@skitt - Can you sign the CLA so that this gets merged? Thank you!

I’m just waiting for our legal department to check it.

sodul commented 5 months ago

@skitt any progress on the CLA? We are staying at v0.2.0 until there is a new release with this fix.

skitt commented 5 months ago

@skitt any progress on the CLA? We are staying at v0.2.0 until there is a new release with this fix.

It’s still pending, sorry...

sodul commented 5 months ago

@JacobOaks I've created an alternate PR (#153) against the latest main (no conflicts) and have signed the CLA. This should allow for mockgen to be released with this issue fixed for good.

FYI, I have contributed to the project before the ownership transfer.

JacobOaks commented 5 months ago

Hey @skitt, closing as superceded by #153. Thanks!

skitt commented 5 months ago

That’s fine @JacobOaks, thanks @sodul for proposing an alternate PR!