search

uber-go / mock

GoMock is a mocking framework for the Go programming language.
Apache License 2.0
1.98k stars 107 forks source link

support type-safe return values #11

Closed tra4less closed 1 year ago

tra4less commented 1 year ago

migrate from https://github.com/golang/mock/pull/630 more: https://github.com/golang/mock/issues/622 https://github.com/golang/mock/issues/427 https://github.com/golang/mock/issues/634 https://github.com/golang/mock/issues/657

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

trim21 commented 1 year ago

can we finally have this feature 😭

sywhang commented 1 year ago

Thank you for submitting this PR. I'll try to get some time to go over this some time later this week or early next week.

High level thoughts - My vote is 👍 for this feature - we've been using a different mocking library internally at Uber that supports type safe return values, and lack of this feature has been a big headache for us as well.

Preventing breaking changes through CLI flag also looks good to me.

sywhang commented 1 year ago

Also cc @linzhp and @r-hang

tra4less commented 1 year ago

@sywhang thanks, your advice is effective.

tra4less commented 1 year ago

Could you please tag this PR? Thank you! @sywhang

sywhang commented 1 year ago

yup, I'll be tagging a version with this along with a few other changes some time this week. Thanks.

tra4less commented 1 year ago

yup, I'll be tagging a version with this along with a few other changes some time this week. Thanks.

get

sywhang commented 1 year ago

@n0trace v0.2.0 is tagged.