search

uber-go / mock

GoMock is a mocking framework for the Go programming language.
Apache License 2.0
1.82k stars 104 forks source link

Improve mock usability in tests #110

Closed feldentm-SAP closed 5 months ago

feldentm-SAP commented 8 months ago 
Add stacktrace on fatal exit of mocked call to allow maintainers of tests using this API to understand what is actually going wrong
CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

feldentm-SAP commented 8 months ago

migrate PR from https://github.com/golang/mock/pull/680

feldentm-SAP commented 8 months ago

@JacobOaks I consider this change a bug fix and would be allowed to donate it to the project without signing the CLA. Signing an Uber CLA is currently not that easy.

JacobOaks commented 8 months ago

Hi @feldentm-SAP - looks like Github is intent on closing this PR on my behalf for some reason (I did not close this and when I try to re-open it immediately closes it). Let me look into it

dobrinkamladenova commented 6 months ago

@JacobOaks, to whom may I forward the executed copy of the CLA?

feldentm-SAP commented 5 months ago

I managed to progress on the legal side, but are now facing technical issues with signing the CLA.

feldentm-SAP commented 5 months ago

@JacobOaks do you know why I'm not allowed to reopen this PR? do you have an idea why I'm presented an empty CLA UI with no means to sign anything?

feldentm-SAP commented 5 months ago

@JacobOaks I finally managed to sign the CLA and would love this PR to get merged

feldentm-SAP commented 5 months ago

@JacobOaks thanks for trying, but I created an identical PR in the meantime to work around this issue: https://github.com/uber-go/mock/pull/145