Closed dlsniper closed 11 months ago
Actual behavior A clear and concise description of what the bug is. The package comments are generated like this:
// mockgen -destination demo/mock.go -package demo . Demoer // // Package demo is a generated GoMock package. package demo
However, this is not correct, as it doesn't follow the package guidelines documented here: https://staticcheck.io/docs/checks#ST1000
Expected behavior A clear and concise description of what you expected to happen.
I expect the generated code to be:
This would follow the guidelines and make the linter happy too.
To Reproduce Steps to reproduce the behavior
mockgen -destination demo/mock.go -package demo . Demoer
Additional Information
source
Triage Notes for the Maintainers
Here's an attempt at fixing the issue: https://github.com/uber-go/mock/pull/112.
Closing since https://github.com/uber-go/mock/pull/112 was merged. Thanks!
Actual behavior A clear and concise description of what the bug is. The package comments are generated like this:
However, this is not correct, as it doesn't follow the package guidelines documented here: https://staticcheck.io/docs/checks#ST1000
Expected behavior A clear and concise description of what you expected to happen.
I expect the generated code to be:
This would follow the guidelines and make the linter happy too.
To Reproduce Steps to reproduce the behavior
mockgen -destination demo/mock.go -package demo . Demoer
on any interface/packageAdditional Information
source
Triage Notes for the Maintainers
Here's an attempt at fixing the issue: https://github.com/uber-go/mock/pull/112.