search

uber-go / mock

GoMock is a mocking framework for the Go programming language.
Apache License 2.0
1.98k stars 107 forks source link

support embedded generic interfaces #13

Closed tra4less closed 1 year ago

tra4less commented 1 year ago

migrate https://github.com/golang/mock/pull/669

fixes https://github.com/golang/mock/issues/668 https://github.com/golang/mock/issues/658 https://github.com/golang/mock/issues/700

tra4less commented 1 year ago

cc @sywhang

sywhang commented 1 year ago

Thanks @n0trace , I'll get to this shortly.

bradleygore commented 1 year ago

Hey @n0trace and @sywhang - I have a similar PR in the origin repo: https://github.com/golang/mock/pull/663 One thing in that PR is that there is some (hopefully good) cleanup around the parse.go file (https://github.com/golang/mock/pull/663/files#diff-eaed3d31482bbbe3987808f6f3e8cf43426d098cd55d0c37699d691fb4da8d85) that I'd love to see make it in if nothing else. I know they just recently flagged the origin repo as archived and such, so I don't want to inundate with PRs especially since the PR in this thread is to solve the same issue 😄

TIA for your consideration, and for taking over this great tool!