uber-go / nilaway

Static analysis tool to detect potential nil panics in Go code
Apache License 2.0
3.06k stars 60 forks source link

new x/tools dep to work with newer go1.23.0 #270

Closed jayalane closed 1 month ago

jayalane commented 1 month ago

As per issue https://github.com/uber-go/nilaway/issues/269 this PR updates go.mod/go.sum to work with go 1.23.0

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

arnested commented 1 month ago

I experience the same problem and this fixes it for me as well.

yuxincs commented 1 month ago

@jayalane , would you mind signing the CLA? Happy to merge the PR once CLA is signed 😃

Thank you for the contributions!

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.60%. Comparing base (58a288b) to head (2b4e65a). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #270 +/- ## ======================================= Coverage 87.60% 87.60% ======================================= Files 63 63 Lines 7916 7916 ======================================= Hits 6935 6935 Misses 799 799 Partials 182 182 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chlanejayasinha commented 1 month ago

Signed. (I had signed it at the time but I put in a different email that I thought was associated to the account but wasn't; just now I signed it with an email that was associated to the account).

chlanejayasinha commented 1 month ago

The failing test looks like it succeeded but then failed to connect back to api.github.com with the results. 403. a

yuxincs commented 1 month ago

The failing test looks like it succeeded but then failed to connect back to api.github.com with the results. 403. a

Yeah it's because the GITHUB_TOKEN in forked repository doesn't have permission to post comments for security reasons. We have fixed this in #273 . I'll update your branch to have the latest changes, and merge once CI passes

github-actions[bot] commented 1 month ago

Golden Test

[!NOTE]
✅ NilAway errors reported on standard libraries are identical.

3271 errors on base branch (main, 58a288b) 3271 errors on test branch (e065d49)

yuxincs commented 1 month ago

Thanks @jayalane!