Closed jayalane closed 1 month ago
I experience the same problem and this fixes it for me as well.
@jayalane , would you mind signing the CLA? Happy to merge the PR once CLA is signed 😃
Thank you for the contributions!
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.60%. Comparing base (
58a288b
) to head (2b4e65a
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Signed. (I had signed it at the time but I put in a different email that I thought was associated to the account but wasn't; just now I signed it with an email that was associated to the account).
The failing test looks like it succeeded but then failed to connect back to api.github.com with the results. 403. a
The failing test looks like it succeeded but then failed to connect back to api.github.com with the results. 403. a
Yeah it's because the GITHUB_TOKEN
in forked repository doesn't have permission to post comments for security reasons. We have fixed this in #273 . I'll update your branch to have the latest changes, and merge once CI passes
[!NOTE]
✅ NilAway errors reported on standard libraries are identical.3271 errors on base branch (main, 58a288b) 3271 errors on test branch (e065d49)
Thanks @jayalane!
As per issue https://github.com/uber-go/nilaway/issues/269 this PR updates go.mod/go.sum to work with go 1.23.0