bcap
commented
2 years ago Ping!
Just found this library and it has helping me doing some basic ratelimiting, so thank you for that :) I am feeling some other features are needed though here, context cancelation being one of them (if there is another lib or fork I should look at, please let me know!). If you are so inclined I can open other issues for features I think it would be nice to have
Regardless, for context cancelation I am currently resorting to this (used within an httpClient impl)
func (c *httpClient) applyRateLimit(ctx context.Context) error {
// the following goroutine + select allow us to abort waiting on
// rate limiting if the request context is done
limitingDone := make(chan struct{})
go func() {
c.limiter.Take()
close(limitingDone)
}()
select {
case <-limitingDone:
return nil
case <-ctx.Done():
return ctx.Err()
}
}
rabbbit
diamondburned
For my future self - #11 tried to do the same. Some code has changed, but the comments there are valuable.
I don't see why we wouldn't extend the API to allow cancellation.