uber-go / sally

A tiny HTTP server for supporting custom Golang import paths
MIT License
317 stars 28 forks source link

feat: Allow packages to define custom documentation URL and badge #147

Closed m5ka closed 5 months ago

m5ka commented 6 months ago

Background

Sally works great in the typical Go documentation ecosystem but when deviating from this it becomes difficult for the documentation badge/URL to be useful, even when specifying a custom godoc.host config variable.

This pull request aims to give a little more freedom with defining the documentation URL and badge image for different packages.

Changes

This is a non-breaking feature (semver minor) change. Existing sally setups will continue to work as expected due to these defaults.

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

JacobOaks commented 6 months ago

Thanks for the PR! I think this LGTM, but I'll wait for another reviewer since I'm newer to Sally.