uber-node / ringpop-node

Scalable, fault-tolerant application-layer sharding for Node.js applications
http://uber.github.io/ringpop/
MIT License
1.18k stars 146 forks source link

Update tchan to 3.6.13 and fix two tests that broke because of it. #243

Closed CorgiMan closed 8 years ago

CorgiMan commented 8 years ago

One test used to add '001' to the hostport to make it unreachable, tchannel doesn't allow huge port no.s anymore. The other test failed because: 'AssertionError: TChannel must listen on top channel'. Listening to the rootChannel fixed the test.

CorgiMan commented 8 years ago

@uber/ringpop

jwolski commented 8 years ago

lgtm

Raynos commented 8 years ago

lgtm