T287803 ring.checksum stats

uber-node / ringpop-node

Scalable, fault-tolerant application-layer sharding for Node.js applications

http://uber.github.io/ringpop/

MIT License

1.18k stars 146 forks source link

Closed benfleis closed 8 years ago

benfleis commented 8 years ago

add {membership,ring}-checksum{,-periodic} stats for partition detection

replaced time-mock with timer-shim, to work with intervals, added small wrapper for trivial compatibility.

@uber/ringpop

dansimau commented 8 years ago

LGTM.

Can I suggest that we stop adding to test/integration/ tests, and instead always add them to the shared integration tests? (@uber/ringpop)

Particularly because this feature has node/go parity, I feel there should be a shared integration test that both pass.

motiejus commented 8 years ago

lgtm

thanodnl commented 8 years ago

lgtm