Refactor the suspicion protocol to a generic timebased state transition.

uber-node / ringpop-node

Scalable, fault-tolerant application-layer sharding for Node.js applications

http://uber.github.io/ringpop/

MIT License

1.18k stars 146 forks source link

Refactor the suspicion protocol to a generic timebased state transition. #248

Closed severb closed 8 years ago

severb commented 8 years ago

This refactoring prepares the ground for reaping faulty nodes.

motiejus commented 8 years ago

Besides the name in the log, LGTM.

severb commented 8 years ago

@Motiejus @thanodnl can you take a second look?

motiejus commented 8 years ago

See some non-blocking comments, so LGTM.

For next time, it would be great to have a non-squashed commit for re-review (since seems like github doesn't support looking between two edits of the same commit).

thanodnl commented 8 years ago

LGTM

severb commented 8 years ago

Ty @Motiejus @thanodnl