Deprecate "admin/reload"-endpoint

[mennopruijssers]

Part of the feedback on #253 was to deprecate the admin/reload-endpoint. The endpoint isn't used by ringpop-admin and, according to our internal metrics, has never been called in production. Triggering a reload was probably useful during testing when the bootstrap file changed. With partition healing, we achieve a similar result in that the discover provider will be re-queried, except that it's automatic.

[dansimau]

+1 for separate PR.

I'd like to add one more justification for deprecating this: triggering a reload was probably useful during testing when the bootstrap file changed. With partition healing, we achieve a similar result in that the discover provider will be re-queried, except that it's automatic.

If we deprecate this, perhaps we should remove these references too:

• https://github.com/uber/ringpop-common/blob/master/test/admin-tests.js#L31
• https://github.com/uber/ringpop-common/blob/master/test/ringpop-assert.js#L743

LGTM

[mennopruijssers]

Good catch on the references in ringpop-common! I opened a PR to remove them (uber/ringpop-common#49)!

[mennopruijssers]

... and changed the description to include your justification :) (I'll make sure it makes the commit message as well ;))