search

uber-node / ringpop-node

Scalable, fault-tolerant application-layer sharding for Node.js applications
http://uber.github.io/ringpop/
MIT License
1.18k stars 146 forks source link

Refactor ping-sender to support sendPingWithChanges #258

Closed mennopruijssers closed 8 years ago

mennopruijssers commented 8 years ago

To support partition healing we need to manually specify the changes sent during a ping-request (instead of gossiping the changes from dissemination). In this case we also don't need to update the membership-list. Both changes are required to be able to send and retrieve changes without marking all the members as faulty before merging partitions.

mennopruijssers commented 8 years ago

PingSender is currently not unit-tested but covered by the integration tests in ringpop-node (and indirectly by the shared integration tests in ringpop-common as well). However, it might be desirable to add unit-tests now or in a separate PR.

CorgiMan commented 8 years ago

Looks good after you have addressed my comments.