search

uber-node / ringpop-node

Scalable, fault-tolerant application-layer sharding for Node.js applications
http://uber.github.io/ringpop/
MIT License
1.18k stars 146 forks source link

add suspect, faulty and tombstone period flags #280

Closed CorgiMan closed 8 years ago

CorgiMan commented 8 years ago

Add suspect, faulty and tombstone period flags so that integration tests can set a small faulty->tombstone period of 5 seconds while having a big faulty->tombstone period when running from tickcluster.

mennopruijssers commented 8 years ago

Same comment on the descriptions as in the go version (uber/ringpop-go#148) but besides that: LGTM.

mennopruijssers commented 8 years ago

Owh, there is a linter error though: 

main.js: line 76, col 29, Missing semicolon. (W033)
CorgiMan commented 8 years ago

Anything else?

motiejus commented 8 years ago

LGTM