Closed dansimau closed 8 years ago
LGTM
The change to the readme looks good and can be merged, but shall we also specify the version in the package.json
under the engines
section
LGTM but let's add the engines
-section as well :)
I'm not completely sure if 0.10.x
is the right version. I was unable to do an install of the dependencies with the following versions:
All seem to have troubles with our package json dependencies section where the ^
is used to ask for compatible versions of packages. Versions that worked for me are the following:
Even though the problem is not with node
but rather with nvm
I wonder if we should specify a higher version of node to make sure that nvm install
works. We can also figure out which version of nvm
has support for ^
versions but I couldn't easily find when support was added. npm@2.8.2
has support (shipped with node@0.10.26
) and npm@1.2.14
(shipped with node@0.10.0
) does not have support.
Ah thanks @thanodnl for looking into this.
Should we specify ^0.10.32
then (that is the version we typically test with anyway)?
Maybe I should do a sanity check of versions above 0.10.32.
Travis tests run on v0.10.45 successfully so I'm just gonna merge this.
LGTM!
Merged in commit ee72383.
Add a section to the README documenting the requirements for ringpop-node.
This should help people run into trouble when trying to
npm install
on a newer version of node1.