[self-evict 1] Support self eviction as a way of graceful shutdown

uber-node / ringpop-node

Scalable, fault-tolerant application-layer sharding for Node.js applications

http://uber.github.io/ringpop/

MIT License

1.18k stars 146 forks source link

[self-evict 1] Support self eviction as a way of graceful shutdown #299

Closed mennopruijssers closed 8 years ago

mennopruijssers commented 8 years ago

This PR adds a way to add self-eviction: marking the local member faulty before shutdown. It adds two functions to ringpop's public API:

registerSelfEvictHooks: Provide a way to register hooks
selfEvict: initiate the self eviction process

TODO in seperate PR(s):

[x] ping members before ending the sequence so the self-eviction is guaranteed to be gossiped (#300)

motiejus commented 8 years ago

My comments are non-blocking, LGTM after you address them.

I am not sure about the order of hooks myself (apart from documenting it), maybe it's not useful at all. I am not very sure in how we intend developers to use them.

thanodnl commented 8 years ago

LGTM

motiejus commented 8 years ago

LGTM