uber-node / ringpop-node

Scalable, fault-tolerant application-layer sharding for Node.js applications
http://uber.github.io/ringpop/
MIT License
1.18k stars 146 forks source link

Allow clients to customize ringpop stats prefix #320

Closed yulunli closed 7 years ago

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

mennopruijssers commented 7 years ago

Overall looks good. Could you add tests to make sure the option is propagated correctly? Also, It looks like statHostPort is never used (except for one test). Lets remove it?