search

uber-node / ringpop-node

Scalable, fault-tolerant application-layer sharding for Node.js applications
http://uber.github.io/ringpop/
MIT License
1.18k stars 146 forks source link

Add option to enforce identical app name in pings #323

Closed yulunli closed 7 years ago

yulunli commented 7 years ago

Always reject pings from wrong app name

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

mennopruijssers commented 7 years ago

Oh, I just saw ringpop-common#97. Can you add the integration test to that one and temporary change the branch name in run-shared-integration-tests:9 temporary until ringpop-common#97 is merged

proflayton commented 7 years ago

this lgtm

yulunli commented 7 years ago

Given we already have a test in ringpop-node, the test in ringpop-common will be added at a later time.