search

uber-node / tcurl

A command line utility to talk to tchannel servers
MIT License
36 stars 7 forks source link

Implement --cn flag to override headers.cn #121

Closed kriskowal closed 8 years ago

kriskowal commented 8 years ago

r @jakev @abhinav

kriskowal commented 8 years ago

See #119 for motivation for --cn fake --sneaky usage.

abhinav commented 8 years ago

LGTM

blampe commented 8 years ago

We do have some services currently whitelisting "tcurl" in particular for health checks soooo maybe break it into 2 diffs? First to add the option, update health checks to continue identifying as tcurl, then change default behavior.

Raynos commented 8 years ago

Agreed; let's avoid changing the health check behaviour. it should probably be "sneaky" by default.

kriskowal commented 8 years ago

Backed out the appended commits and amended to “be sneaky by default”

DAddYE commented 8 years ago

Shouldn't this be documented in the command line help?