tcurl should accept hostnames for the host when making a request

uber-node / tcurl

A command line utility to talk to tchannel servers

MIT License

36 stars 7 forks source link

tcurl should accept hostnames for the host when making a request #125

Open prashantv opened 8 years ago

prashantv commented 8 years ago

$ tcurl -p hyperbahn01-sjc1:21300 moe --health
NOT OK
Error response received for the as-thrift request.
AssertionError: Expected host to contain IPv4
{"ok":false,"name":"AssertionError","message":"Expected host to contain IPv4","isError":true,"isErrorFrame":false}

$ tcurl --version
4.19.1

yhorbachov commented 8 years ago

@prashantv tcurl uses tchannel to create connections, which has checking for valid IPv4 address. I don`t know why developers decided to check it (tchannel uses vanilla node 'net' module to create sockets, which accepts hostnames and IP addresses) but it is as it is.

I created issue in tchannel issues list Issue-327.