search

uber-node / tcurl

A command line utility to talk to tchannel servers
MIT License
36 stars 7 forks source link

Need the ability to send Ringpop Transport Header #28

Closed rssathe closed 9 years ago

rssathe commented 9 years ago

tcurl doesn't have a --headers flag that allows us to send transport tchannel headers

rssathe commented 9 years ago

There are existing linter issues/ test issues that I haven't fixed not sure if anything should be done about those.

Also this was tested manually on my Tchannel Service I am writing

jcorbin commented 9 years ago

Is discussed on #29, please tell us more about what your needs are, transport headers are meant to be a tightly controlled internal detail, and not for arbitrary user extensible headers.

rssathe commented 9 years ago

@jcorbin as @Raynos mentioned it is The use case is for tcurling ringpop services which expect shard keys in transport headers

Raynos commented 9 years ago

@rssathe We've had a change of heart; exposing --headers leaks too much implementation detail.

Can we change it to --shardKey=... ?

rssathe commented 9 years ago

@Raynos done