uber-node / tcurl

A command line utility to talk to tchannel servers
MIT License
36 stars 7 forks source link

Add transport header argv closes #28 #29

Closed rssathe closed 9 years ago

Raynos commented 9 years ago

lgtm.

jcorbin commented 9 years ago

This probably makes sense for now, but:

Chances are high that things that are "transport headers" in v2 will shift to be a first class fixed field in v3 (e.g. the cn header), so I really consider exposing transport headers to be a maintenance liability. That all said, the current state of the tcurl tool is quite debt-ridden, and we need to change a lot of things (perhaps including the entire CLI experience).

Raynos commented 9 years ago

@jcorbin

The use case is --headers='{"sk":"uuid"}' for tcurling ringpop services.

TChannel already exposes headers as an arbitrary string/string bag you can put any data you want into. We really need to make a breaking change there if the desire is to limit transport headers.

andrewdeandrade commented 9 years ago

Ugg, stupid git rebase. Can I just squash all these commits and force push over this branch (or push onto a new branch) so this produces a clean history after merging with master?

cc/ @Raynos @rssathe

rssathe commented 9 years ago

@malandrew fine by me