search

uber-node / tcurl

A command line utility to talk to tchannel servers
MIT License
36 stars 7 forks source link

Unlock semver of tchannel and fix back-incompat as-http #74

Closed kriskowal closed 8 years ago

kriskowal commented 8 years ago

r @anson627 @ShanniLi @malandrew cc @jcorbin

anson627 commented 8 years ago

thanks for the fix! I didn't realize sendRequest is being used as a public interface.

Ideally we should require tchannel to be passed in from constructor and use it going forward, the send/forward methods should not take tchannel as argument.

anson627 commented 8 years ago

:+1:

jcorbin commented 8 years ago

lgtm

Raynos commented 8 years ago

Unlocking semver is risky without adding running the tcurl tests to travis CI for tchannel.

anson627 commented 8 years ago

agree, we need link test for tcurl then.