search

uber-node / tcurl

A command line utility to talk to tchannel servers
MIT License
36 stars 7 forks source link

Add error for missing Thrift IDL argument #86

Closed kriskowal closed 8 years ago

kriskowal commented 8 years ago

tcurl infers as=thrift from :: in an arg1, but still needs a -t for the Thrift IDL file now. We will eventually hit Meta::thriftIDL if we don’t have -t, but this gives us an understandable error for now.

r @ShanniLi @malandrew

ShanniLi commented 8 years ago

So, this will prevent "::" style for non-thrift endpoints. Not sure we want to enforce it. I think we need to have a cross language consensus on this style requirement before we move forward.

kriskowal commented 8 years ago

The consequence is that you have to express --json explicitly if arg1 contains "::".

kriskowal commented 8 years ago

Pushed another. This clarifies that the error can be resolved either with --thrift or --json.

ShanniLi commented 8 years ago

lgtm