search

uber-node / zero-config

A zero configuration configuration loader
MIT License
116 stars 10 forks source link

So Secret #15

Closed sh1mmer closed 9 years ago

sh1mmer commented 9 years ago

cc @Raynos @lxe @recht @aegarbutt

Raynos commented 9 years ago

lgtm. We should bikeshed about where the secrets.json should live.

I personally dont care, but last I heard it was ./secrets/secrets.json

kriskowal commented 9 years ago

lgtm.

Raynos commented 9 years ago

lgtm. Let's agree on a folder location with @aegarbutt and others before we merge.

lxe commented 9 years ago

lgtm. I like config/secrets-env.json

@aegarbutt Let's not move them to the folder... or add the folder support alongside with config/secrets-env.json

Raynos commented 9 years ago

lgtm.

recht commented 9 years ago

In clay, you can define in the main config file which files you want to have merged in - couldn't it be an idea to do the same here - something like

{
  "normal_property": false,
  "debug": {
    "enabled": true
  },
  "@includes": [
    "./config/debug_secrets.json"
  ]
}

where the included files would be deep merged into the main config? Then the config loader itself doesn't have to know about any locations at all...