search

uber-node / zero-config

A zero configuration configuration loader
MIT License
116 stars 10 forks source link

Fix secrets directory structure #16

Closed lxe closed 9 years ago

lxe commented 9 years ago

cc @sh1mmer @Raynos

sh1mmer commented 9 years ago

This lgtm. Can I get a second?

kriskowal commented 9 years ago

Looks correct. New policy is secrets/secrets-$NODE_ENV.json, where $NODE_ENV is "production" or "test" or whatnot.

Raynos commented 9 years ago

lgtm.

lxe commented 9 years ago

Looks correct. New policy is secrets/secrets-$NODE_ENV.json, where $NODE_ENV is "production" or "test" or whatnot.

@kriskowal so uh it's no longer config/secrets-$NODE_ENV?

kriskowal commented 9 years ago

@lxe, no ignore me. I mis-read what I was seeing.

lxe commented 9 years ago

@kriskowal lol because secrets/secrets-NODE_ENV would be a lot better...