uber-web / ocular

Build tools for the vis.gl framework suite
https://uber-web.github.io/ocular
MIT License
44 stars 23 forks source link

Bug: Check CHANGELOG updates before bumping version. #468

Open ibgreen opened 3 months ago

ibgreen commented 3 months ago
Pessimistress commented 3 months ago
  1. Changelog enforcement is not defined in ocular-dev-tools
  2. You can simply reset all changes before publishing again
ibgreen commented 3 months ago

Changelog enforcement is not defined in ocular-dev-tools

OK, then I not sure where it is enforced, see package.json. But it is notable that the changes are made and pushed before the CHANGELOG check fails, so in that case it seems that ocular-dev-tools invokes some other script that has the potential to fail after making the changes.

  "scripts": {
    "bootstrap": "ocular-bootstrap",
    "postinstall": "echo postinstall",
    "start": "open https://luma.gl/docs/getting-started",
    "clean": "ocular-clean",
    "build": "ocular-clean && (cd modules/constants && yarn pre-build) && ocular-build",
    "cover": "ocular-test cover",
    "lint": "ocular-lint",
    "publish-beta": "ocular-publish version-only-beta",
    "publish-prod": "ocular-publish version-only-prod",
    "version": "node scripts/verify-changelog.js && git add CHANGELOG.md",
    "test": "ocular-test",
    "test-ci": "ocular-lint && ocular-test node && ocular-test cover && yarn test-website",
    "test-fast": "ocular-test fast",
    "test-browser": "ocular-test browser",
    "test-browser-headless": "ocular-test browser-headless | tap-spec",
    "test-website": "cd website && yarn && yarn build && cd ..",
    "perf": "ocular-test perf-browser",
    "bench": "ocular-test bench",
    "bench-browser": "ocular-test bench-browser",
    "metrics": "./scripts/metrics.sh && ocular-metrics"
ibgreen commented 3 months ago

You can simply reset all changes before publishing again

Well,