uber / NullAway

A tool to help eliminate NullPointerExceptions (NPEs) in your Java code with low build-time overhead
MIT License
3.63k stars 293 forks source link

DO NOT LAND TESTING BENCHMARKING #1048

Closed msridhar closed 2 weeks ago

msridhar commented 2 weeks ago

This reverts commit 8305c2ce8660eb51a00b6ac7e0b42f22eea98a1f.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 87.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.54%. Comparing base (f3837e8) to head (91127c6).

Files with missing lines Patch % Lines
.../contract/fieldcontract/EnsuresNonNullHandler.java 84.61% 2 Missing and 2 partials :warning:
...c/main/java/com/uber/nullaway/NullabilityUtil.java 85.71% 0 Missing and 1 partial :warning:
.../nullaway/dataflow/AccessPathNullnessAnalysis.java 92.30% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1048 +/- ## ========================================== Coverage 87.54% 87.54% + Complexity 2165 2138 -27 ========================================== Files 85 83 -2 Lines 7114 7003 -111 Branches 1386 1367 -19 ========================================== - Hits 6228 6131 -97 + Misses 458 451 -7 + Partials 428 421 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

Main Branch:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25  10.183 ± 0.105  ops/s
CaffeineBenchmark.compile         thrpt   25   3.798 ± 0.030  ops/s
DFlowMicroBenchmark.compile       thrpt   25  28.157 ± 0.276  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.457 ± 0.048  ops/s

With This PR:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25  10.383 ± 0.142  ops/s
CaffeineBenchmark.compile         thrpt   25   3.787 ± 0.036  ops/s
DFlowMicroBenchmark.compile       thrpt   25  28.468 ± 0.100  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.467 ± 0.027  ops/s