codecov[bot]
commented
1 week ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.61%. Comparing base (
0f6f3d2) to head (495f179). Report is 1 commits behind head on master.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1054 +/- ## ========================================= Coverage 87.61% 87.61% Complexity 2183 2183 ========================================= Files 85 85 Lines 7161 7161 Branches 1404 1404 ========================================= Hits 6274 6274 Misses 453 453 Partials 434 434 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
lazaroclapp
I did not have the artifacts from building SDK 31 from source available to me, so I couldn't run JarInfer on them directly. Instead, I wrote this code to convert our extant astubx file to the new format. The main change is that now method signatures use qualified type names. To do the conversion, I looked up methods from the astubx file in the android.jar stubs file (using WALA) and then got the qualified type names from there.
Not every method present in the previous astubx file is present in the android.jar stubs, as many methods in AOSP are hidden and cannot be invoked (at least not easily), but those methods were included in our previous astubx. This explains why the new astubx is smaller. I did my best to carefully debug and make sure we weren't missing other methods unnecessarily.
This is not a long-term solution. We will probably want to continue to evolve the astubx format, and we'll need a new conversion script each time. Eventually we should create a new astubx for the latest Android SDK and possibly deprecate these artifacts for older SDKs. But, this solution unblocks us, as our current astubx for SDK 31 is unusable with the main branch astubx parsing code.