search

uber / NullAway

A tool to help eliminate NullPointerExceptions (NPEs) in your Java code with low build-time overhead
MIT License
3.63k stars 293 forks source link

Fix bug with computing direct type use annotations on parameters #864

Closed msridhar closed 11 months ago

msridhar commented 11 months ago

NullAway was still treating annotations on generic type arguments as being on the top-level type of a parameter itself, which could lead to false positives and potentially also missed bugs.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9092438) 87.02% compared to head (ae1cbb4) 87.02%. Report is 2 commits behind head on master.

Files Patch % Lines
...ava/com/uber/nullaway/generics/GenericsChecks.java 87.50% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #864 +/- ## ========================================= Coverage 87.02% 87.02% - Complexity 1921 1922 +1 ========================================= Files 77 77 Lines 6219 6219 Branches 1209 1210 +1 ========================================= Hits 5412 5412 Misses 403 403 Partials 404 404 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.